Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deffered send #1833

Merged
merged 18 commits into from
Oct 23, 2023
Merged

Feature/deffered send #1833

merged 18 commits into from
Oct 23, 2023

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Oct 6, 2023

Description of the Change

Send approvals and assignments as a batched message pack.
Crash fix.

iceseer and others added 10 commits October 6, 2023 10:32
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
This reverts commit 0612580.

Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer requested review from xDimon and igor-egorov October 13, 2023 08:14
Copy link
Contributor

@kamilsa kamilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant logs please

Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer requested a review from kamilsa October 18, 2023 06:52
kamilsa and others added 5 commits October 18, 2023 18:47
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>

# Conflicts:
#	core/consensus/grandpa/impl/grandpa_impl.cpp
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer force-pushed the feature/defered_send branch from 9b7db41 to f386bbd Compare October 23, 2023 08:11
@iceseer iceseer enabled auto-merge (squash) October 23, 2023 08:12
@iceseer iceseer merged commit 9443ffc into master Oct 23, 2023
@iceseer iceseer deleted the feature/defered_send branch October 23, 2023 08:14
iceseer added a commit that referenced this pull request Dec 7, 2023
This reverts commit 9443ffc.

Signed-off-by: iceseer <iceseer@gmail.com>

# Conflicts:
#	core/consensus/grandpa/impl/grandpa_impl.cpp
#	core/network/helpers/stream_read_buffer.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants